chore: pre-release maintenance (test counts, fuzz fix, code cleanup)#885
Merged
chore: pre-release maintenance (test counts, fuzz fix, code cleanup)#885
Conversation
Spec test cases: 2382→2278 (2354 pass→2252, 28 skip→26). Added new test files (exec-command, compgen-path, ls, nameref-assoc, set-allexport, subprocess-isolation, test-tty). Updated per-file counts and skip annotations. Updated threat_model_tests count from 50+ to 185.
Remove misleading #[allow(dead_code)] from AwkExpr enum (variants are used). Keep it only on Match which is genuinely unconstructed. Convert redundant TODO comment to descriptive comment since the error message already communicates the limitation.
Fuzz input `[${#[` (bytes [91,36,123,35,91]) triggered a panic in
expand_brace_expr_in_arithmetic: when rest="[" and bracket=0,
the slice rest[1..0] panicked with "byte range starts at 1 but ends
at 0". Guard against bracket+1 > end before slicing.
Crash found by arithmetic_fuzz in CI (Mar 22, 24, 26 failures).
Adds regression test under TM-DOS-029.
chaliy
force-pushed
the
claude/run-maintenance-fIcsd
branch
from
d7f6f36 to
f6e2da0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release maintenance pass per
specs/012-maintenance.md.${#[}in arithmetic expansion — found byarithmetic_fuzzCI (intermittent failures Mar 22/24/26). Adds regression test under TM-DOS-029.#[allow(dead_code)]annotations and redundant TODO in AWK builtin.012-maintenance.mdto track large-scope items found during maintenance passes.Deferred to separate issues
${#[}— intermittent CI failures #882 — Fuzz crash tracking issue (fixed in this PR)Maintenance checklist results
cargo denyclean, 1 allowed advisoryTest plan
cargo test --all-features— all passcargo clippy --all-targets --all-features -- -D warnings— cleancargo fmt --check— cleanarithmetic_malformed_brace_length_no_panicpasses